Added Zod Validation for OAuth Authentication Initiation Endpoints#585
Merged
Merged
Conversation
|
@sheeeuWu is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @sheeeuWu, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — SKIP
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Zod schema validation to the /auth/github and /auth/google OAuth initiation endpoints. previously, query parameters (state, mobile_redirect_uri) were consumed directly without schema validation
Closes #538
Type of Change
What Changed
src/validators/auth.validation.ts: added oAuthStartSchema with Zod validation for state and mobile_redirect_uri, including a refine check that enforces the devcard:// schemesrc/routes/auth.ts: replaced manual query destructuring and inline mobile_redirect_uri check in /auth/github and /auth/google with oAuthStartSchema.safeParse(), removed now unused GoogleAuthQuery interfacesrc/__tests__/auth.test.ts: added route-level integration tests covering valid and invalid query params for both endpointssrc/__tests__/auth.validation.test.ts: added unit tests for oAuthStartSchema directlyHow to Test
auth.test.tsshould passChecklist
pnpm -r run lintpasses).pnpm -r run typecheck).pnpm -r run test).console.logor debug statements left in the code.