fix(backend): remove any usages from profiles.ts to improve type safety by Satvik-art-creator · Pull Request #589 · Dev-Card/DevCard

Satvik-art-creator · 2026-06-17T01:19:14Z

Summary

This PR improves type safety in the profile routes by removing the remaining usages of any in apps/backend/src/routes/profiles.ts. By leveraging existing Fastify request typings and Prisma error classes, this makes the route handlers and error handling logic safer and more maintainable.

This issue is solved under GSSoC '26.

Closes #552

Type of Change

What Changed

apps/backend/src/routes/profiles.ts: Replaced request.server as any and (app as any).authenticate with properly typed Fastify instance property access (request.server and app.authenticate), leveraging the existing FastifyInstance augmentation in fastify.d.ts.
apps/backend/src/routes/profiles.ts: Replaced all instances of (request.user as any).id with request.user.id, utilizing the native JWT authentication typings.
apps/backend/src/routes/profiles.ts: Replaced unsafe catch (err: any) with catch (err: unknown) and utilized Prisma.PrismaClientKnownRequestError to safely trap P2002 (unique constraint) errors.

How to Test

Check out this branch locally: git checkout fix/profile-ts-types
Ensure you have the backend dependencies installed and Prisma generated: cd apps/backend && npm install
Run the TypeScript compiler to ensure there are no implicit any errors: npm run typecheck
Optionally, start the backend and update a profile/link to verify authentication and database calls work exactly as before.

Checklist

My code follows the project's coding style (pnpm -r run lint passes).
TypeScript compiles without errors (pnpm -r run typecheck).
I have added or updated tests for the changes I made. (N/A - Type updates only)
All tests pass locally (pnpm -r run test).
I have updated documentation where necessary. (N/A)
No new console.log or debug statements left in the code.
Breaking changes are documented in this PR description. (N/A)

Additional Context

No application behavior or logic has been altered. This PR simply removes TS-compiler overrides to improve the codebase quality and safety.

vercel · 2026-06-17T01:19:20Z

@Satvik-art-creator is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2026-06-17T01:19:27Z

Hi @Satvik-art-creator,

Thanks for opening this pull request.

This PR has been automatically classified based on the files modified.

Applied Labels

gssoc:approved
backend

Primary Review Area

backend

Reviewer

@Harxhit has been identified as the primary reviewer for this pull request.

If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer.

Thank you for your contribution!

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR tightens type safety in the profiles routes by removing any casts, using typed request.user, and improving Prisma error handling for unique-constraint conflicts.

Changes:

Replace (request.user as any).id with request.user.id across profile endpoints.
Update error handling to catch unknown and narrow Prisma errors via PrismaClientKnownRequestError.
Remove any usage around authenticate access on request.server / app.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    const server = request.server;
    if (typeof server?.authenticate === 'function') {
      await server.authenticate(request, reply);
      return;
    }
-    if (typeof (app as any).authenticate === 'function') {
-      await (app as any).authenticate(request, reply);
+    if (typeof app.authenticate === 'function') {
+      await app.authenticate(request, reply);
      return;
    }



  app.get('/me', async (request: FastifyRequest, reply: FastifyReply) => {
-    const userId = (request.user as any).id;
+    const userId = request.user.id;


github-actions · 2026-06-17T01:20:11Z

CI — All Checks Passed

Backend — PASS

Check	Result
Lint	PASS
Test	PASS
Typecheck	PASS

Mobile — SKIP

Check	Result
Lint	-
Test	-

Web — SKIP

Check	Result
Build	-

Last updated: Wed, 17 Jun 2026 01:36:19 GMT

Harxhit

Clean, well-scoped refactor — the any removals are all correct against the existing fastify.d.ts augmentation (request.user is typed as AuthenticatedUser, and FastifyInstance.authenticate is declared), so request.user.id and app.authenticate type-check without casts. Replacing err: any + err?.code === 'P2002' with err instanceof Prisma.PrismaClientKnownRequestError && err.code === 'P2002' is the right pattern, and the unused getProfileUrl / getErrorMessage imports were correctly dropped. A couple of small inline notes below.

Harxhit · 2026-06-17T04:40:50Z

+import { updateProfileSchema, createLinkSchema, reorderLinksSchema } from '../utils/validators.js';

+import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
+// eslint-disable-next-line @typescript-eslint/no-unused-vars


ProfileUpdateResponse is now suppressed with an eslint-disable for being unused rather than removed. The PR description says no behavior changes and this type isn't referenced anywhere — prefer deleting the dead type outright over silencing the linter. If it's intentionally kept as living API documentation, a one-line comment saying so would be clearer than the bare disable.

Harxhit · 2026-06-17T04:40:50Z

    }
-    if (typeof (app as any).authenticate === 'function') {
-      await (app as any).authenticate(request, reply);
+    if (typeof app.authenticate === 'function') {


Now that the casts are gone, the typing makes the redundancy here visible: request.server is the app instance, so the server?.authenticate branch (line 25) and this app.authenticate branch are the same decorator — and FastifyInstance.authenticate is now declared non-optional in fastify.d.ts, so the typeof === 'function' guards and the jwtVerify fallback are effectively dead code. Out of scope for a pure type-safety PR, but worth a follow-up to collapse this to a single await app.authenticate(request, reply).

Harxhit · 2026-06-17T04:40:50Z

-    } catch (err: any) {
-      if (err?.code === 'P2002') return reply.status(409).send({ error: 'Username already taken' })
+    } catch (err: unknown) {
+      if (err instanceof Prisma.PrismaClientKnownRequestError && err.code === 'P2002') {


Good change. Since Prisma is now imported solely for this guard, just confirm @prisma/client is generated in CI before typecheck/lint runs (the import resolves to generated types) — otherwise lint/typecheck could fail on a clean checkout.

Harxhit

LGTM. Approving

github-actions · 2026-06-17T04:44:55Z

Congratulations @Satvik-art-creator on getting PR #589 merged!

Thank you for your contribution to the project.

To receive the appropriate GSSoC labels and recognition, please mention @Harxhit in the #get-labels channel on our Discord server and share your merged PR link.

Copilot AI review requested due to automatic review settings June 17, 2026 01:19

github-actions Bot added backend gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. labels Jun 17, 2026

Copilot AI reviewed Jun 17, 2026

View reviewed changes

fix(backend): remove any usages from profiles.ts to improve type safety

1077cb5

Satvik-art-creator force-pushed the fix/profile-ts-types branch from 1d4858f to 1077cb5 Compare June 17, 2026 01:35

Harxhit reviewed Jun 17, 2026

View reviewed changes

Harxhit approved these changes Jun 17, 2026

View reviewed changes

Harxhit merged commit 5fffad9 into Dev-Card:main Jun 17, 2026
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(backend): remove any usages from profiles.ts to improve type safety#589

fix(backend): remove any usages from profiles.ts to improve type safety#589
Harxhit merged 1 commit into
Dev-Card:mainfrom
Satvik-art-creator:fix/profile-ts-types

Satvik-art-creator commented Jun 17, 2026

Uh oh!

vercel Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jun 17, 2026 •

edited

Loading

Uh oh!

Harxhit left a comment

Uh oh!

Harxhit Jun 17, 2026

Uh oh!

Harxhit Jun 17, 2026

Uh oh!

Harxhit Jun 17, 2026

Uh oh!

Harxhit left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Satvik-art-creator commented Jun 17, 2026

Summary

Type of Change

What Changed

How to Test

Checklist

Additional Context

Uh oh!

vercel Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Applied Labels

Primary Review Area

Reviewer

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI — All Checks Passed

Backend — PASS

Mobile — SKIP

Web — SKIP

Uh oh!

Harxhit left a comment

Choose a reason for hiding this comment

Uh oh!

Harxhit Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Harxhit Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Harxhit Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Harxhit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 17, 2026 •

edited

Loading