Scheduler - Appointment Form - Fix layout when labelLocation is static #32255
+145
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes layout issues in the Scheduler appointment form when labelMode is set to 'static'. The fix dynamically adjusts icon positioning based on whether form field labels are positioned at the top or inline.
Changes:
- Added dynamic icon alignment logic that detects label positioning and applies appropriate CSS classes
- Removed hardcoded CSS margin rules and replaced them with conditional class-based styling
- Added visual regression tests for
labelMode='static'scenarios
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts |
Added new CSS class constants and alignIconsWithEditors() method to dynamically apply margin classes to icons based on label positioning |
packages/devextreme-scss/scss/widgets/generic/scheduler/_sizes.scss |
Added new SCSS variable for icon inner-label margin-top in generic theme |
packages/devextreme-scss/scss/widgets/generic/scheduler/_index.scss |
Added CSS rule for .dx-scheduler-form-inner-label-offset class |
packages/devextreme-scss/scss/widgets/base/scheduler/_index.scss |
Moved margin-top from icon to top-label-offset class, removed hardcoded overrides |
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/recurrence-form.visual.ts |
Added visual test for recurrence form with labelMode='static' |
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/form.visual.ts |
Added visual test for main appointment form with labelMode='static' |
packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts
Outdated
Show resolved
Hide resolved
sjbur
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.