T1308327 - DataGrid - Cell value is not restored after canceling changes in cell editing mode if repaintChangesOnly is enabled #32290
+141
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive integration test to verify the fix for T1308327, which addresses an issue where DataGrid cell values were not properly restored after canceling changes in cell editing mode when repaintChangesOnly is enabled. The test ensures that validation states are correctly reset along with the cell values.
Changes:
- Added new integration test for validating cell value restoration after cancel with validation errors
- Extended test model infrastructure to support interaction with revert buttons and cell editors
- Verified the fix works for multiple consecutive cell edits and cancellations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/validating/tests/validating.integration.test.ts | New integration test file verifying cell value restoration when canceling edits with validation errors in repaintChangesOnly mode |
| packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/grid_core.ts | Added getRevertButton() helper method to enable test interaction with validation revert buttons |
| packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/cell/data_cell.ts | Added getEditor() helper method to retrieve and interact with cell editors in tests |
…he revert button get access to initial values via _getOldData()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.