Get rid of keyboard trap#255
Merged
Merged
Conversation
Raushen
reviewed
Jul 21, 2026
| const { format } = context; | ||
| const isInTable = format.tableCellLine || format.tableHeaderCellLine | ||
| || format.tableHeaderCell || format.table; | ||
| || format.tableHeaderCell || format.table; |
Author
There was a problem hiding this comment.
It's actually better to add extra spaces here to visually connect the line with the previous one
There was a problem hiding this comment.
In the monorepo we have other lint rules, it seems we should follow the same code style everywhere. Ok, if you insist we can leave it as is. Let's discuss linter rules later.
Raushen
reviewed
Jul 21, 2026
Raushen
reviewed
Jul 21, 2026
| tab: { | ||
| key: 'tab', | ||
| handler(range, { format }) { | ||
| handler(range, context) { |
There was a problem hiding this comment.
We could leave destructurisation still here: { format }
Author
There was a problem hiding this comment.
it would be less obvious if I do destructuring here, I'd prefer to do destructuring inside the body
Raushen
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.