-
-
Notifications
You must be signed in to change notification settings - Fork 4
Release v0.5.4 #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.4 #278
Changes from all commits
ce4661a
521ce1c
9345289
c8317eb
6530094
7f65782
cdd20a0
077ae76
d3cad15
7cc8f16
786b33c
221be15
98fca31
bc93cba
16ef693
82d01ea
b7c49a5
4041589
124bc04
4bffb88
be2ddbb
0b726bf
1128c88
7edf42b
d0a0586
c606ab4
d73f5fb
c23f2c0
f1730f3
7a353d1
9ace93d
91a7a93
77936b6
45d6e83
4585ddb
fb63cc3
eaf3eb0
2afb681
e969382
cad16e7
2e015ba
579512e
2bcafdd
d6d4906
9ade51d
9615bff
0c12d6a
2f9aca2
7b8f89a
c2ac8e4
d33349e
239436f
601e032
f7c7b63
07b59c8
3b9588e
bf21695
09654b9
06db3e8
fa8ecaf
4694478
1ad1d7f
f7bfae4
274a218
b3cdf48
6d678fc
10f1434
9b1bf11
9d99457
fc64c59
4ef0806
622cde3
0e2c3c4
895654d
839ac57
ca5fc1f
725561e
8e6b4cb
56f76e5
6cf267b
3d9e744
bd93adf
638d0a4
8af9a6c
be76fca
8ef0ad2
cdf4460
c253133
3df6b02
a8afc1c
ffb9d68
277c945
d0d6406
9c0a867
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| defaults and fully supports es6-module |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ export default async function HomePage({ | |
| </h2> | ||
|
|
||
| <Link | ||
| href="/shop/products?filter=new" | ||
| href="/shop/products?filter=newest" | ||
| className="group border-border text-muted-foreground hover:text-foreground focus-visible:ring-offset-background inline-flex items-center gap-2 rounded-md border bg-transparent px-4 py-2 text-xs font-semibold tracking-[0.25em] uppercase shadow-none transition-[transform,box-shadow,color,filter] duration-500 ease-out hover:-translate-y-0.5 hover:shadow-[var(--shop-card-shadow-hover)] hover:brightness-110 focus-visible:ring-2 focus-visible:ring-[color:var(--color-ring)] focus-visible:ring-offset-2 focus-visible:outline-none sm:text-sm" | ||
| aria-label={t('viewAll')} | ||
|
Comment on lines
54
to
57
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: rg -n "filter.*newest|newest.*filter" --type=tsx --type=ts -C 3Repository: DevLoversTeam/devlovers.net Length of output: 98 🏁 Script executed: # Also check the products page to see how it handles filter parameters
fd "products" --type=f -e tsx -e ts | head -20Repository: DevLoversTeam/devlovers.net Length of output: 370 🏁 Script executed: # Search for filter parameter handling in general
rg -n "filter=|filter:" --type=tsx --type=ts -C 2 | grep -A 5 -B 5 "shop/products"Repository: DevLoversTeam/devlovers.net Length of output: 98 🏁 Script executed: rg -n "newest" --type=ts -C 3Repository: DevLoversTeam/devlovers.net Length of output: 4664 🏁 Script executed: # Check the CatalogProductsClient to see how it handles filter parameters
cat -n frontend/components/shop/CatalogProductsClient.tsx | head -100Repository: DevLoversTeam/devlovers.net Length of output: 3520 🏁 Script executed: # Check the products.ts query file
cat -n frontend/db/queries/shop/products.ts | head -100Repository: DevLoversTeam/devlovers.net Length of output: 3042 🏁 Script executed: # Search for filter parameter handling more broadly
rg -n "filter" frontend/components/shop/ -C 2Repository: DevLoversTeam/devlovers.net Length of output: 3486 🏁 Script executed: # Check the full catalog route handler to see if filter=newest is handled
cat -n frontend/app/api/shop/catalog/route.tsRepository: DevLoversTeam/devlovers.net Length of output: 3350 🏁 Script executed: # Check the catalogQuerySchema to see what parameters it accepts
rg -n "catalogQuerySchema" --type=ts -B 5 -A 15Repository: DevLoversTeam/devlovers.net Length of output: 9428 🏁 Script executed: # Check the products page to see how it handles filter=newest
cat -n frontend/app/\[locale\]/shop/products/page.tsx | head -60Repository: DevLoversTeam/devlovers.net Length of output: 2293 🏁 Script executed: # Verify what happens when filter parameter doesn't match any legacy case
rg -n "filter" frontend/app/\[locale\]/shop/products/page.tsx -B 2 -A 2Repository: DevLoversTeam/devlovers.net Length of output: 668 Use The link uses 🤖 Prompt for AI Agents |
||
| > | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The support link is rendered as a non-interactive span.
The
supportLinktranslation key suggests this should be a clickable link, but it's rendered as a<span>with button styling and no interaction handlers. If this is intentional (e.g., a placeholder for future functionality or just a decorative badge), consider:aria-hidden="true"if purely decorativesupportBadgeIf it should be interactive, wrap it in a
<Link>or<a>element with the appropriate destination.🤖 Prompt for AI Agents