fix: resolve npm peer dependency conflict blocking CI#91
Merged
iqbalhasandev merged 8 commits intomainfrom Apr 12, 2026
Merged
Conversation
Add .npmrc with legacy-peer-deps=true so npm ci resolves peer dependency version mismatches that block CI installation.
There was a problem hiding this comment.
Pull request overview
This PR aims to unblock CI by allowing npm ci to complete despite an ESLint peer dependency mismatch by relaxing npm’s peer dependency resolution.
Changes:
- Added a repository-level
.npmrcenablinglegacy-peer-deps. - (Per PR description) Regenerated dependency lockfile using the relaxed peer dependency behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Peer dep @inertiajs/react was not installed as a devDependency, causing tsc to fail with TS2307 when resolving imports in source files.
Remove project-wide .npmrc legacy-peer-deps setting as it affects all npm installs including local dev. Instead, pass --legacy-peer-deps directly to npm ci in CI workflows. Needed until eslint-plugin-react officially supports eslint@10.
…t 19 - Add react-dom, @testing-library/dom and @types/react-dom as explicit devDependencies (were silently skipped by --legacy-peer-deps) - Add Jest moduleNameMapper shim for react-dom/test-utils which was removed in React 19 but still unconditionally required by @testing-library/react internals
Rename react-dom-test-utils-shim.js to .cjs so it is ignored by ESLint. Update eslint.config.js ignore pattern from *.cjs to **/*.cjs so CJS files in subdirectories are also excluded from linting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm ciwas failing in all CI jobs due to a peer dependency version conflict:Neither package has released a version that officially supports the other's major version yet.
Fix
Added
.npmrcwithlegacy-peer-deps=trueso npm uses the relaxed peer dependency resolution algorithm, allowing installation to succeed. The lock file has been regenerated with this setting applied.Test plan
npm cisucceeds in CI