Skip to content

fix: resolve npm peer dependency conflict blocking CI #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iqbalhasandev merged 1 commit into from
Apr 12, 2026
Merged

fix: resolve npm peer dependency conflict blocking CI #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting legacy-peer-deps=true disables peer-dependency enforcement for all installs in this repo, which can mask real incompatibilities (not just ESLint) and lead to broken tooling/runtime behavior that only shows up later. Prefer resolving the underlying mismatch by aligning versions (e.g., downgrade eslint to a range supported by the React/React-Hooks plugins, or upgrade those plugins to versions that explicitly support eslint@10), and use legacy-peer-deps only as a temporary/CI-only workaround if unavoidable (document it with a comment in this file).

Suggested change
legacy-peer-deps=true

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description attributes the peer-dependency conflict only to eslint-plugin-react, but this repo also uses eslint-plugin-react-hooks@7.0.1, which (per its peerDependency range) does not declare support for eslint@10 either. Please update the PR description/root-cause explanation (or dependency plan) so it accurately reflects all conflicting peers being bypassed by legacy-peer-deps.

Copilot uses AI. Check for mistakes.