Feature/ipc proxy calls#181
Merged
kannananil merged 2 commits intoNov 3, 2025
Merged
Conversation
Gauravpadam
force-pushed
the
feature/ipc-proxy-calls
branch
from
9ffb7ff to
aae6f10
Compare
Collaborator
|
@Gauravpadam, thanks for making these changes I will look into it and get back to you with my reviews. |
kannananil
reviewed
Oct 28, 2025
kannananil
left a comment
kannananil
left a comment
Collaborator
There was a problem hiding this comment.
@Gauravpadam thanks for your efforts, except that vitest.config.mts change all other changes looks good, could you just revert that change alone and we can proceed to merge.
I have checked out your branch and tried a high level sanity with it in local it was working fine as well.
…ndlers with tests and migrate from axios to IPC-based API calls Remove paneloader from exclusion
Gauravpadam
force-pushed
the
feature/ipc-proxy-calls
branch
from
aae6f10 to
7519d41
Compare
Contributor
Author
|
@kannananil I would request for another review |
kannananil
approved these changes
Nov 3, 2025
kannananil
left a comment
kannananil
left a comment
Collaborator
There was a problem hiding this comment.
@Gauravpadam, sorry for the delay. The latest changes looks we can proceed to merge. Thank you very much for your efforts.
Contributor
Author
|
Thanks @kannananil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
@kannananil the tests and some code is ai written. Although I have moderated it well, I'd appreciate reviews from your end to align expectations.
I also had to change the axios based fetching to custom fetching for the ipc handler, that's why I had to change a few tests to match the ApiResponse type interface.