Encapsulate drive train functions within the drive train class - #26
Open
rekhask wants to merge 2 commits into
Open
Encapsulate drive train functions within the drive train class#26rekhask wants to merge 2 commits into
rekhask wants to merge 2 commits into
Conversation
ParkerMeyers
self-requested a review
April 7, 2022 02:34
ParkerMeyers
approved these changes
Apr 7, 2022
ParkerMeyers
left a comment
ParkerMeyers
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good! Merging is fine w/ me.
ParkerMeyers
self-requested a review
April 7, 2022 02:39
ParkerMeyers
suggested changes
Apr 7, 2022
ParkerMeyers
left a comment
ParkerMeyers
left a comment
Contributor
There was a problem hiding this comment.
Re-Reviewing due to failed build. I cannot see why the build is failing, but please check on this next meeting. Also, minor code suggestions.
| } | ||
|
|
||
| public double getLeftMasterVoltage(){ | ||
| return getLeftMaster().getMotorOutputVoltage(); |
Contributor
There was a problem hiding this comment.
Motors are defined in the same file, can just call to leftMaster variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.