Skip to content

Replace external PATH executable lookup #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into from
Apr 8, 2026
+353 −53
Merged

Replace external PATH executable lookup #4563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 184 additions & 0 deletions src/UniGetUI.Core.Tools.Tests/ToolsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,164 @@ public async Task TestWhichFunctionForNonExistingFile()
Assert.Equal("", result.Item2);
}

[Fact]
public void TestWhichFunctionForDirectPath()
{
string tempDirectory = CreateTemporaryDirectory();
string commandPath = Path.Combine(
tempDirectory,
OperatingSystem.IsWindows() ? "unigetui-direct-path-test.cmd" : "unigetui-direct-path-test"
);

try
{
CreateCommandFile(commandPath);

Tuple<bool, string> result = CoreTools.Which(commandPath);

Assert.True(result.Item1);
Assert.Equal(commandPath, result.Item2);
}
finally
{
Directory.Delete(tempDirectory, true);
}
}

[Fact]
public void TestWhichMultipleRespectsProcessPathOrder()
{
string tempDirectory1 = CreateTemporaryDirectory();
string tempDirectory2 = CreateTemporaryDirectory();
string commandName = OperatingSystem.IsWindows()
? "unigetui-path-order-test.exe"
: "unigetui-path-order-test";
string commandPath1 = Path.Combine(tempDirectory1, commandName);
string commandPath2 = Path.Combine(tempDirectory2, commandName);
string? oldPath = Environment.GetEnvironmentVariable("PATH", EnvironmentVariableTarget.Process);

try
{
CreateCommandFile(commandPath1);
CreateCommandFile(commandPath2);
Environment.SetEnvironmentVariable(
"PATH",
string.Join(Path.PathSeparator, tempDirectory1, tempDirectory2),
EnvironmentVariableTarget.Process
);

List<string> result = CoreTools.WhichMultiple(commandName);

Assert.Equal([commandPath1, commandPath2], result);
}
finally
{
Environment.SetEnvironmentVariable(
"PATH",
oldPath,
EnvironmentVariableTarget.Process
);
Directory.Delete(tempDirectory1, true);
Directory.Delete(tempDirectory2, true);
}
}

[Fact]
public void TestWhichFunctionResolvesPathextOnWindows()
{
if (!OperatingSystem.IsWindows())
{
return;
}

string tempDirectory = CreateTemporaryDirectory();
string commandPath = Path.Combine(tempDirectory, "unigetui-pathext-test.exe");
string? oldPath = Environment.GetEnvironmentVariable("PATH", EnvironmentVariableTarget.Process);
string? oldPathExt = Environment.GetEnvironmentVariable(
"PATHEXT",
EnvironmentVariableTarget.Process
);

try
{
CreateCommandFile(commandPath);
Environment.SetEnvironmentVariable(
"PATH",
tempDirectory,
EnvironmentVariableTarget.Process
);
Environment.SetEnvironmentVariable(
"PATHEXT",
".EXE;.CMD",
EnvironmentVariableTarget.Process
);

Tuple<bool, string> result = CoreTools.Which("unigetui-pathext-test");

Assert.True(result.Item1);
Assert.Equal(commandPath, result.Item2, StringComparer.OrdinalIgnoreCase);
}
finally
{
Environment.SetEnvironmentVariable(
"PATH",
oldPath,
EnvironmentVariableTarget.Process
);
Environment.SetEnvironmentVariable(
"PATHEXT",
oldPathExt,
EnvironmentVariableTarget.Process
);
Directory.Delete(tempDirectory, true);
}
}

[Fact]
public void TestWhichFunctionRequiresExecutableBitOnUnix()
{
if (OperatingSystem.IsWindows())
{
return;
}

string tempDirectory = CreateTemporaryDirectory();
string commandName = "unigetui-unix-executable-bit-test";
string commandPath = Path.Combine(tempDirectory, commandName);
string? oldPath = Environment.GetEnvironmentVariable("PATH", EnvironmentVariableTarget.Process);

try
{
File.WriteAllText(commandPath, string.Empty);
File.SetUnixFileMode(
commandPath,
UnixFileMode.UserRead
| UnixFileMode.UserWrite
| UnixFileMode.GroupRead
| UnixFileMode.OtherRead
);
Environment.SetEnvironmentVariable(
"PATH",
tempDirectory,
EnvironmentVariableTarget.Process
);

Tuple<bool, string> result = CoreTools.Which(commandName);

Assert.False(result.Item1);
Assert.Equal("", result.Item2);
}
finally
{
Environment.SetEnvironmentVariable(
"PATH",
oldPath,
EnvironmentVariableTarget.Process
);
Directory.Delete(tempDirectory, true);
}
}

[Theory]
[InlineData("7zip19.00-helpEr", "7zip19.00 HelpEr")]
[InlineData("packagename", "Packagename")]
Expand Down Expand Up @@ -242,5 +400,31 @@ public void TestFormatSize(long size, int decPlaces, string expected)
{
Assert.Equal(CoreTools.FormatAsSize(size, decPlaces).Replace(',', '.'), expected);
}

private static string CreateTemporaryDirectory()
{
string path = Path.Combine(Path.GetTempPath(), $"UniGetUI-ToolsTests-{Guid.NewGuid():N}");
Directory.CreateDirectory(path);
return path;
}

private static void CreateCommandFile(string path)
{
File.WriteAllText(path, string.Empty);

if (!OperatingSystem.IsWindows())
{
File.SetUnixFileMode(
path,
UnixFileMode.UserRead
| UnixFileMode.UserWrite
| UnixFileMode.UserExecute
| UnixFileMode.GroupRead
| UnixFileMode.GroupExecute
| UnixFileMode.OtherRead
| UnixFileMode.OtherExecute
);
}
}
}
}
Loading
Loading