Fix missing AdminByRequest patches#4
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intorelease/v2.6.1from Apr 13, 2026
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
force-pushed
the
fix/adminbyrequest-patches
branch
from
2f5259d to
8cbac6b
Compare
4 tasks
Marc-André Moreau (mamoreau-devolutions)
deleted the
fix/adminbyrequest-patches
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the missing AdminByRequest-related source changes onto
release/v2.6.1.Problem
When UniGetUI Elevator was migrated into
gsudo-distro, the AdminByRequest port was incomplete. The release branch kept the upstreamStartElevatedDetached(...).GetSafeProcessHandle()path, which fails when AdminByRequest launches a transient shim process and that process exits before gsudo tries to access the handle.Changes
Processobject in the service start pathStartElevatedDetacheda fire-and-forget launch for the UAC-elevation pathRunCommandgsudoserviceandgsudoelevateValidation
gsudofornet9.0with/p:DisableGitVersionTask=trueUniElevatewith/p:BuildVariant=UniElevate /p:DisableGitVersionTask=trueRelated: Devolutions/UniGetUI#4579, Devolutions/UniGetUI#3913