Recursive version bump when using defines#43
Open
mount40 wants to merge 3 commits intoDevriX:masterfrom
Open
Conversation
… all asset files.
…nction is completely self-contained.
mount40
changed the title
xavortm
reviewed
Dec 23, 2019
| * | ||
| * @package DevriX_Starter | ||
| */ | ||
| function dx_get_assets_version( $dir ) { |
Contributor
There was a problem hiding this comment.
Add function description, do not glue it to the file description on top
functions.php
Outdated
| * @package DevriX_Starter | ||
| */ | ||
| function dx_get_assets_version( $dir ) { | ||
| $rii = new RecursiveIteratorIterator( new RecursiveDirectoryIterator( $dir ) ); |
Contributor
There was a problem hiding this comment.
Improve the variable names, $rii is not descriptive at all
functions.php
Outdated
| */ | ||
| function dx_get_assets_version( $dir ) { | ||
| $rii = new RecursiveIteratorIterator( new RecursiveDirectoryIterator( $dir ) ); | ||
| $files = array(); |
Contributor
There was a problem hiding this comment.
Fix code formatting, you have to follow WP coding standards on all lines, tabs here seem wrong
functions.php
Outdated
| function dx_get_assets_version( $dir ) { | ||
| $rii = new RecursiveIteratorIterator( new RecursiveDirectoryIterator( $dir ) ); | ||
| $files = array(); | ||
| $assets_m_time = array(); |
Contributor
There was a problem hiding this comment.
Again improve name, what is m?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.