feat: add ulims authz policy#310
Open
MattPrit wants to merge 3 commits into
Open
Conversation
eb36e68 to
6e60748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Adds authZ policy for use in ULIMS services. Essentially, this moves the existing ULIMS policy into the central repository, with the addition of service account support and a new rule for filtering a list of instruments
Added rules:
allow- top-level check that the user has been verifiedsession_restrictions- returns the sessions that the user has access to, in the format[{"beamline": "i03", "proposal_number": 1, "visit_number": 1}, ...]filter_sessions- given an inputinstrument_sessionsof (proposal number, session number) pairs, return those pairs corresponding to session that the user has access tofilter_instruments- given an in putinstruments, a list of instrument names, return those that the user has access to (i.e is an admin of)Note: There is a section of policy that I have copied from
tiled.regoNote: Some of the rules depend on
token.claims.beamline, I suspect that more generally we would liketoken.claims.instruments, but I have usedbeamlinefor consistency withtiled.rego