Skip to content

Hint data attributes on fp adapter#108

Open
shihab-dls wants to merge 1 commit intomainfrom
add_fp_data_signals
Open

Hint data attributes on fp adapter#108
shihab-dls wants to merge 1 commit intomainfrom
add_fp_data_signals

Conversation

@shihab-dls
Copy link
Copy Markdown
Contributor

@shihab-dls shihab-dls commented Apr 23, 2026

This adds type hints for the following attributes into FrameProcessorAdapterController:

    data_compression: AttrRW[str]
    data_datatype: AttrRW[str]
    data_dims_0: AttrR[int]  # y
    data_dims_1: AttrR[int]  # x

This is defined in EigerFrameProcessorAdapterController on fastcs_eiger, but fastcs-jungfrau needs these attributes too, so we should redefine it here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (93b56df) to head (80d80cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   96.38%   96.40%   +0.02%     
==========================================
  Files          16       16              
  Lines         636      640       +4     
==========================================
+ Hits          613      617       +4     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls shihab-dls requested a review from ajgdls April 23, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant