Skip to content

Usb pump#6

Merged
UrszulaNeuman merged 12 commits intomainfrom
usb_pump
Apr 21, 2026
Merged

Usb pump#6
UrszulaNeuman merged 12 commits intomainfrom
usb_pump

Conversation

@UrszulaNeuman
Copy link
Copy Markdown
Collaborator

Adapt the driver to work with the new pump that uses the USB connection.
Adds an important change to the way the pump numbers work.
A pump number pv has been added. It is set by the operator and once set all the settings are directed to the pvs of the chosen pump number. This behaviour is in line with the manual operation of the pump and works well. Constant changes of the pump number every time a pv value was changed did no work well (slowed down the communication and occasionally messed up the synchronisation).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 42.12329% with 169 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.10%. Comparing base (0da3c02) to head (3e40419).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs_wpi_micro4/wpi_micro4_controller.py 15.78% 32 Missing ⚠️
src/fastcs_wpi_micro4/usb_connection.py 50.90% 27 Missing ⚠️
...s_wpi_micro4/wpi_micro4_controller_type_setting.py 46.00% 27 Missing ⚠️
..._wpi_micro4/wpi_micro4_controller_state_setting.py 47.61% 22 Missing ⚠️
...pi_micro4/wpi_micro4_controller_command_setting.py 29.62% 19 Missing ⚠️
..._wpi_micro4/wpi_micro4_controller_value_setting.py 24.00% 19 Missing ⚠️
...s_wpi_micro4/wpi_micro4_controller_line_setting.py 59.25% 11 Missing ⚠️
...c/fastcs_wpi_micro4/wpi_micro4_controller_query.py 35.29% 11 Missing ⚠️
src/fastcs_wpi_micro4/__main__.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
- Coverage   68.75%   49.10%   -19.65%     
===========================================
  Files           3       11        +8     
  Lines          64      391      +327     
===========================================
+ Hits           44      192      +148     
- Misses         20      199      +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@UrszulaNeuman UrszulaNeuman merged commit bb3bac2 into main Apr 21, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant