Update FIBContext and backend logic for detecting, handling and making GIFs of drift correction images#796
Open
Update FIBContext and backend logic for detecting, handling and making GIFs of drift correction images#796
Conversation
…ow module and optimised input parameters required
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 52.14% 52.29% +0.15%
==========================================
Files 96 96
Lines 10239 10316 +77
Branches 1340 1357 +17
==========================================
+ Hits 5339 5395 +56
- Misses 4627 4642 +15
- Partials 273 279 +6 🚀 New features to boost your workflow:
|
…cessed files to for each lamella site; updated output file determination logic when creating FIB GIFs to reflect this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the logic on the client and backend server used to construct GIFs of the drift correction images.
yyyy-mm-dd-hh-mm-ssconvention, which allow them to be sorted as stringsDiff due to tests is about +270/-110.