docs: two citations pointed at the sibling repo, and the version badge froze nine releases ago - #338
Merged
Conversation
…badge to manifest (#335) Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #333
Closes #335
#333 —
hooks.d/before_session_start/50-git-restore.sh:313andtests/test_git_restore_hook_253.py:463both citeddocs/validators.md, which belongs toclaude-supertooland has never existed here. The three-state contract they were pointing at is real and does live in this repo, just elsewhere: the 0.12.0 CHANGELOG entry states it, and_push_and_reportinhooks.d/after_save/50-git-backup.shimplements it. Both citations now point there. Swept for other cross-repo path references — none remain.#335 — the README badge read
0.8.3while the manifest declared0.18.0. Nine releases, on the front page, hyperlinked to the very file it disagreed with.The bump is five seconds; the durable half is why it went unnoticed for nine releases. A release sweep keyed on the version being replaced only finds sites that are mid-bump — a zero from it means "nothing is half-done", never "everything is right". It is structurally incapable of seeing a field frozen at some third value, which is exactly the field most likely to be wrong.
So
test_readme_version_badge_matches_codejoins the guards, and it fails on an unmatched pattern rather than passing. A regex that finds nothing has not checked the badge — that distinction is the whole point of the test.RED:
GREEN:
tests/test_version_manifest.py: 5 passedChose the static bump plus a pinning test over the shields.io dynamic-JSON badge the issue also floated — the dynamic one trades a silent drift for a runtime dependency on shields.io resolving a raw GitHub URL, and the test makes drift structurally impossible anyway. CI fails; it does not merely miss it.
Full suite run locally before push: green.