This repository was archived by the owner on Jul 10, 2019. It is now read-only.
Make Annotation's serializable and initial implementation of adding annotations to the Exporter output#56
Open
lewismc wants to merge 1 commit intoDigitalPebble:masterfrom
Conversation
…nnotations to the Exporter output
Member
|
Hi @lewismc - will have a closer look when coming back from holiday. Thanks |
Author
|
Enjoy holidays @jnioche safe travels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jnioche ,
Please see the patch below which does the following
An issue is that the concatenation is not a join.
What do you think about the patch. Is it worthy of inclusion into Behemoth?