fix: show remaining/total instead of used/remaining in status bar#11
Closed
DimazzzZ wants to merge 0 commit into
Closed
fix: show remaining/total instead of used/remaining in status bar#11DimazzzZ wants to merge 0 commit into
DimazzzZ wants to merge 0 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (remaining != null && total != null) { | ||
| return when (format) { | ||
| StatusBarFormat.COMPACT -> "${formatShortDollars(remaining)} / ${formatShortDollars(total)}" | ||
| StatusBarFormat.DESCRIPTIVE -> "${formatShortDollars(remaining)} of ${formatShortDollars(total)} remaining" |
| if (remaining != null && total != null) { | ||
| return when (format) { | ||
| StatusBarFormat.COMPACT -> "${formatShortDollars(remaining)} / ${formatShortDollars(total)}" | ||
| StatusBarFormat.DESCRIPTIVE -> "${formatShortDollars(remaining)} of ${formatShortDollars(total)} remaining" |
| if (remaining != null && total != null) { | ||
| return when (format) { | ||
| StatusBarFormat.COMPACT -> "${formatShortDollars(remaining)} / ${formatShortDollars(total)}" | ||
| StatusBarFormat.DESCRIPTIVE -> "${formatShortDollars(remaining)} of ${formatShortDollars(total)} remaining" |
| if (remaining != null && total != null) { | ||
| return when (format) { | ||
| StatusBarFormat.COMPACT -> "${formatShortDollars(remaining)} / ${formatShortDollars(total)}" | ||
| StatusBarFormat.DESCRIPTIVE -> "${formatShortDollars(remaining)} of ${formatShortDollars(total)} remaining" |
| if (remaining != null && total != null) { | ||
| return when (format) { | ||
| StatusBarFormat.COMPACT -> "${formatShortDollars(remaining)} / ${formatShortDollars(total)}" | ||
| StatusBarFormat.DESCRIPTIVE -> "${formatShortDollars(remaining)} of ${formatShortDollars(total)} remaining" |
| if (remaining != null && total != null) { | ||
| return when (format) { | ||
| StatusBarFormat.COMPACT -> "${formatShortDollars(remaining)} / ${formatShortDollars(total)}" | ||
| StatusBarFormat.DESCRIPTIVE -> "${formatShortDollars(remaining)} of ${formatShortDollars(total)} remaining" |
DimazzzZ
force-pushed
the
fix/status-bar-format-order
branch
from
b068064 to
21a2a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the status bar format order for "Used / Remaining" option to show "remaining / total" instead of "used / remaining".
Why
Users expected to see "$57 / $1443" (remaining / total) but were seeing "$1443 / $57" (used / remaining). The format should show how much is remaining out of the total balance.
Changes
formatUsedOfRemaininginBalanceFormatter.ktto prefer "remaining / total" format when total is availableFiles Modified
src/main/kotlin/org/zhavoronkov/tokenpulse/ui/BalanceFormatter.ktsrc/test/kotlin/org/zhavoronkov/tokenpulse/ui/BalanceFormatterTest.ktVerification