fix: resolve NPE in CliConnectDialog due to constructor-time access of subclass state#16
Merged
Merged
Conversation
…f subclass state
The abstract class CliConnectDialog declared open properties (headerHtml,
descriptionHtml, requirementsHtml) that were read during base-class init{},
before subclass field initializers had completed. In Kotlin/JVM this allows
overridden non-null vals to be observed as null at construction time,
causing a NullPointerException in RowImpl.label(text).
Fix:
- Replace abstract value properties with a constructor-parameter CliDialogSpec,
eliminating constructor-time polymorphic access.
- Move CLI detection start out of base init{} into a protected startDetection()
method, called from each subclass init{} after base construction finishes.
Affected dialogs (both updated accordingly):
- CodexConnectDialog
- ClaudeConnectDialog
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ngth violations Extracted long inline HTML strings in detectCli() into private helper methods (detectingStatusHtml, notFoundStatusHtml, detectedStatusHtml, errorMessageHtml, versionHtml). This eliminates the detekt line-length warnings reported on PR #16 while keeping the constructor-safety fix intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The abstract class CliConnectDialog declared open/abstract properties (headerHtml, descriptionHtml, requirementsHtml) that were read during base-class init{}, before subclass field initializers had completed. In Kotlin/JVM this allows overridden non-null vals to be observed as null at construction time, causing a NullPointerException in RowImpl.label(text).
Fix
Validation