Skip to content

Add support for filter effects#64

Merged
nicoburns merged 29 commits into
mainfrom
filters
Jun 4, 2026
Merged

Add support for filter effects#64
nicoburns merged 29 commits into
mainfrom
filters

Conversation

@nicoburns
Copy link
Copy Markdown
Member

@nicoburns nicoburns commented Jun 2, 2026

This is based on the implementation from vello_common (https://docs.rs/vello_common/0.0.9/vello_common/filter_effects/index.html). Differences from that implementation:

  • Filter and FilterGraph are collapsed into one type (named Filter)
  • Filter is not internally Arc'd. The intention is that APIs will explicit accept Arc<Filter>. The advantage of this design is that allows sub-Filters to be composed without allocating intermediate Arcs, and without needing a separate type (FilterGraph).
  • FilterFunction and FilterEffect have been removed. You should use what is called FilterPrimitive in vello_common, or convenience constructors on Filter instead. The FilterPrimitive type has been renamed to FilterEffect now that name is available.
  • CompoundFilter has been removed.
  • All struct-like enums have been split out into standalone structs
  • Serde derives have been added to all the types.

@nicoburns nicoburns force-pushed the filters branch 3 times, most recently from 2b72cce to f2d71ab Compare June 2, 2026 16:10
nicoburns added 11 commits June 2, 2026 17:19
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns added 2 commits June 2, 2026 17:46
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
@nicoburns nicoburns marked this pull request as ready for review June 4, 2026 14:29
@nicoburns nicoburns merged commit b013dd2 into main Jun 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant