Skip to content

Add config compatibility matrix tests for entry/route aliases#56

Closed
Disaster-Terminator wants to merge 1 commit intoreview/route-contract-hardening-2026-05-05from
add-tests-for-config-loading-combinations
Closed

Add config compatibility matrix tests for entry/route aliases#56
Disaster-Terminator wants to merge 1 commit intoreview/route-contract-hardening-2026-05-05from
add-tests-for-config-loading-combinations

Conversation

@Disaster-Terminator
Copy link
Copy Markdown
Owner

Motivation

  • Ensure backward-compatible loading of new product-facing keys while preserving legacy keys and preventing regressions.
  • Provide a compact compatibility matrix so future edits do not accidentally break existing local configs.

Description

  • Added focused compatibility tests in tests/test_config.py covering entry_model and route_model alias handling and mixed-key behavior.
  • Added tests for fallback_route_id and legacy default_route alias handling.
  • Added a regression test verifying omitted target_model resolves to each route's route_id, and recursive-protection tests that entry_model/route_model cannot be a route_id and fallback_route_id must exist.
  • Chose a deterministic compatibility rule that legacy route_model takes precedence when both route_model and entry_model are present, and documented that rule in the test code.

Testing

  • Ran uv run python -m pytest -q, which passed: 157 passed, 1 warning.
  • Ran uv run python scripts/eval_routes.py --mock-embeddings, which passed: 10 eval case(s) passed.

Codex Task

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Disaster-Terminator! 👋

Your private repo does not have access to Sourcery.

Please upgrade to continue using Sourcery ✨

@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant