Add redacted route quality review runbook, synthetic fixture, and tests#57
Closed
Disaster-Terminator wants to merge 1 commit intoreview/route-contract-hardening-2026-05-05from
Conversation
There was a problem hiding this comment.
Hi @Disaster-Terminator! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
expectis a product-levelroute_idand not a deploymenttarget_model.Description
docs/runbooks/redacted-route-quality-review.mddescribing JSONL collection rules, required fields (text,expect,redacted), import and review flows, and safe PASS/FAIL interpretation.tests/samples/redacted_review_fixture.jsonlthat containsredacted:trueandexpect:"strong"for tooling checks.tests/test_import_review_samples.pyto importPathand add two tests that assert the fixture remains redacted and thatconvert_review_samplesaccepts it when validating against a set of allowedroute_ids.Testing
uv run python -m pytest -qand all tests passed (152 passed, 1 warning).uv run python scripts/eval_routes.py --mock-embeddingsand the eval run completed successfully (10 eval case(s) passed).Codex Task