Add golden fixtures and contract tests for structured route logs#59
Merged
Disaster-Terminator merged 1 commit intoreview/route-contract-hardening-2026-05-05from May 5, 2026
Conversation
There was a problem hiding this comment.
Hi @Disaster-Terminator! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
dc103cd
into
review/route-contract-hardening-2026-05-05
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
router_log_summary.pyandcheck_route_error_budget.py) handle mixed records (explicitroute_id,null/passthrough, and missingroute_id) and malformed trailing JSON gracefully.Description
tests/samples/router_logs_contract.ndjsonthat includesroute_complete,route_error, a passthrough (route_id: null), a legacy log missingroute_id, a startup non-route line, and a trailing malformed JSON line.tests/test_router_log_summary.pythat parse the fixture withparse_route_recordsand assert totals,routesvstargetsbuckets,error_types, and parse diagnostics, and a safety test that asserts forbidden sensitive patterns are not present in the fixture.tests/test_check_route_error_budget.pythat exercisescheck_budgeton the fixture with permissiveBudgetConfigand assertstarget_error_rates,route_error_rates(includingunknownfor missing route IDs),error_types, and parse diagnostics.Testing
uv run python -m pytest -qand the test suite passed (153 passed, 1 warning).uv run python scripts/router_log_summary.py --json < tests/samples/router_logs_contract.ndjsonwhich produced a JSON summary successfully showing expected counts and diagnostics.uv run python scripts/check_route_error_budget.py < tests/samples/router_logs_contract.ndjsonwhich executed the CLI reading from stdin and printed a failing budget result (non-zero exit) because the fixture intentionally contains route errors; the fixture-driven unit test forcheck_budgetuses a permissiveBudgetConfigand passed underpytest.Codex Task