Add operator runbook and redacted fixture guardrails for route review#60
Merged
Disaster-Terminator merged 1 commit intoreview/route-contract-hardening-2026-05-05from May 5, 2026
Conversation
There was a problem hiding this comment.
Hi @Disaster-Terminator! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
d9e888f
into
review/route-contract-hardening-2026-05-05
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
expectas a product-levelroute_id(nottarget_model) so imports and audits compare stable route identifiers.Description
docs/redacted_route_review_runbook.mddescribing how to collect redacted samples, required JSONL fields, import with route validation, how to runreview_decisionsagainst the decision endpoint, and how to interpretPASS/FAILsafely.tests/samples/redacted_review_samples.synthetic.jsonlto serve as an operator sanity-check sample that containsredacted:true,text, andexpectset to aroute_id.tests/test_import_review_samples.pywith two tests that assert the fixture remains strictly redacted and non-empty and thatconvert_review_samplessucceeds when validating against allowed route ids, and addPathimport used by those tests.Testing
uv run python -m pytest -q, which completed successfully with all tests passing (152 passed, 1 warning).uv run python scripts/eval_routes.py --mock-embeddings, which executed the mock eval cases and reported the expected passes (10 eval case(s) passed).Codex Task