Make menu bar visible whatever dialog has focus#1864
Merged
windymilla merged 1 commit intoMay 25, 2026
Conversation
Tk9 on Macs only displays the root menu bar when the root window has focus, not if a dialog has focus. Assign the root menu bar to all dialogs. Testing: Check if it breaks Tk8 version on Macs
tangledhelix
approved these changes
May 25, 2026
Member
tangledhelix
left a comment
tangledhelix
left a comment
There was a problem hiding this comment.
Tested with Python 3.13.5 / Tk 8 and Python 3.14.5 / Tk 9. Menus stay consistent as I open S/R, Bookloupe, WF, Regex Library, etc. Looks good.
windymilla
added a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tk9 on Macs only displays the root menu bar when the root window has focus, not if a dialog has focus.
Assign the root menu bar to all dialogs.
Testing: Check if it breaks Tk8 version on Macs. If it does, we'll need
if is_mac() and is_tk9()but I'd rather avoid explicit Tk9 testing where possible.