-
Notifications
You must be signed in to change notification settings - Fork 0
유튜브 동영상 임베드 기능 구현 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| 'use client'; | ||
|
|
||
| import YouTube, { YouTubeProps } from 'react-youtube'; | ||
|
|
||
| type Props = { | ||
| videoId: string; | ||
| title: string; | ||
| }; | ||
|
|
||
| export const YouTubeEmbed = ({ videoId, title }: Props) => { | ||
| const opts: YouTubeProps['opts'] = { | ||
| width: '100%', | ||
| height: '100%', | ||
| playerVars: { | ||
| autoplay: 0, | ||
| modestbranding: 1, | ||
| rel: 0, | ||
| }, | ||
| }; | ||
|
|
||
| return ( | ||
| <div className='relative my-8 aspect-video w-full'> | ||
| <YouTube | ||
| className='absolute top-0 left-0 h-full w-full' | ||
| opts={opts} | ||
| title={title} | ||
| videoId={videoId} | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { YouTubeEmbed as YouTube } from './YouTubeEmbed'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opts객체는 렌더링될 때마다 재생성될 필요가 없는 상수입니다. 컴포넌트 외부로 옮겨서 불필요한 재생성을 방지하는 것이 좋습니다. 이렇게 하면 성능에 미미하지만 긍정적인 영향을 줄 수 있고, 코드의 의도를 더 명확하게 표현할 수 있습니다.