🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in RSS feeds

[Doezer]

🚨 Severity: HIGH
💡 Vulnerability: The /api/rss/feeds POST and PUT endpoints were vulnerable to Server-Side Request Forgery (SSRF) as they did not sanitize the user-provided RSS feed URL before making internal HTTP requests.
🎯 Impact: Attackers could provide internal network URLs (like http://localhost:5100/api/health or internal IP spaces), forcing the server to make requests on their behalf, potentially exposing internal services or causing a Denial of Service.
🔧 Fix: Added explicit await isSafeUrl(url) checks from server/ssrf.ts to both endpoints. If the URL is found to be unsafe, the endpoints now return a 400 Bad Request with an appropriate error message.
✅ Verification: Ran the test suite using npm test and ensured ssrf-routes.test.ts passed correctly. Also verified npm run build and npm run lint were successful.

---

PR created automatically by Jules for task 870104645251400991 started by @Doezer

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical security vulnerability by implementing robust URL validation on the RSS feed creation and update endpoints. The changes prevent potential Server-Side Request Forgery attacks, significantly enhancing the application's security posture by ensuring that user-provided URLs are safe before any internal HTTP requests are made.

Highlights

• SSRF Vulnerability Fixed: The /api/rss/feeds POST and PUT endpoints were vulnerable to Server-Side Request Forgery (SSRF) due to a lack of URL sanitization. This allowed attackers to force the server to make requests to internal network resources.
• URL Safety Checks Implemented: Explicit await isSafeUrl(url) checks from server/ssrf.ts have been added to both the POST and PUT RSS feed endpoints. If an unsafe URL is detected, the API now returns a 400 Bad Request error.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
server/routes.ts	50.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

The pull request introduces URL validation for RSS feed creation and updates. Specifically, it adds a call to isSafeUrl for the POST /api/rss/feeds endpoint to validate the URL before adding a new feed, and similarly for the PUT /api/rss/feeds/:id endpoint to validate the URL if it's being updated. If an unsafe URL is detected, the API now returns a 400 Bad Request error, enhancing the security and robustness of the application.