Fix #172: Plezy Wants to "Play" Photos#20
Fix #172: Plezy Wants to "Play" Photos#20google-labs-jules[bot] wants to merge 5 commits intomainfrom
Conversation
- Added `PhotoViewerScreen` to display photos with zoom capability. - Updated `media_navigation_helper.dart` to route `PlexMediaType.photo` to `PhotoViewerScreen` instead of `MediaDetailScreen`. - This resolves the issue where photos were being treated as playable media with play buttons and duration.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
@jules update navigation, menus... To support photo browsing |
I have updated the navigation logic to ensure that photos open in a dedicated |
- Added `PhotoViewerScreen` to display photos with zoom capability. - Updated `media_navigation_helper.dart` to route `PlexMediaType.photo` to `PhotoViewerScreen`. - Updated `media_context_menu.dart` to hide "Mark as Watched/Unwatched" for photos. - Updated `media_card.dart` to fix accessibility labels for photos.
|
@jules |
I have addressed the linter warnings and errors:
|
- Added `PhotoViewerScreen` to display photos with zoom capability. - Updated `media_navigation_helper.dart` to route `PlexMediaType.photo` to `PhotoViewerScreen`. - Updated `media_context_menu.dart` to hide "Mark as Watched/Unwatched" for photos and fix null safety issues. - Updated `media_card.dart` to fix accessibility labels for photos. - Removed unused `upscale` parameter and unnecessary import in `photo_viewer_screen.dart`.
|
@jules warning • The operand can't be 'null', so the condition is always 'false' • lib/screens/photo_viewer_screen.dart:60:30 • unnecessary_null_comparison |
I have removed the unnecessary null comparison in |
- Added `PhotoViewerScreen` to display photos with zoom capability. - Updated `media_navigation_helper.dart` to route `PlexMediaType.photo` to `PhotoViewerScreen` instead of `MediaDetailScreen`. - Updated `media_context_menu.dart` to hide "Mark as Watched/Unwatched" for photos and fixed nullable access compilation errors. - Updated `media_card.dart` to fix accessibility labels for photos. - Removed unused imports and invalid parameters in `photo_viewer_screen.dart` to fix linter warnings.
|
warning • The '!' will have no effect because the receiver can't be null • lib/widgets/media_context_menu.dart:219:60 • unnecessary_non_null_assertio
|
I have removed the unnecessary non-null assertion on |
- Added `PhotoViewerScreen` to display photos with zoom capability. - Updated `media_navigation_helper.dart` to route `PlexMediaType.photo` to `PhotoViewerScreen` instead of `MediaDetailScreen`. - Updated `media_context_menu.dart` to hide "Mark as Watched/Unwatched" for photos and fixed nullable access compilation errors. - Updated `media_card.dart` to fix accessibility labels for photos. - Removed unused imports, invalid parameters, and unnecessary null checks in `photo_viewer_screen.dart` to fix linter warnings. - Fixed unnecessary non-null assertion in `media_context_menu.dart`.
This PR fixes issue edde746#172 where tapping on a photo would open the MediaDetailScreen with play buttons and duration, which is incorrect for photos.
Changes:
lib/screens/photo_viewer_screen.dart: A new screen that displays the photo usingInteractiveViewerfor zooming. It supports both online (viaCachedNetworkImage) and offline (viaDownloadProviderandImage.file) modes.lib/utils/media_navigation_helper.dart: Added logic to check forPlexMediaType.photoand navigate toPhotoViewerScreeninstead of the defaultMediaDetailScreen.This ensures that photos are displayed correctly as images, avoiding the confusion of video playback controls. Note that next/previous navigation is not yet implemented as
navigateToMediaItemcurrently only receives a single metadata item.PR created automatically by Jules for task 6079812600399769104 started by @Doezer