Open
Conversation
…tedDisk and logs. When installation is completed successfully, the context is saved so on refresh the success screen is persisted rather than going back to the start of the installation workflow.
Contributor
Author
|
@SomeoneWeird I'm looking for some feedback on this approach, is the store a good place to implement this? |
| store.updateState({ | ||
| setupContext: { | ||
| ...this.context.store.setupContext, | ||
| isCompleted: true |
Contributor
There was a problem hiding this comment.
Hmm, this is going to persist in cookies and break dev setup the next time you drop into recovery mode?
| this._install_outcome = didErr ? "error" : "success" | ||
|
|
||
| if (this._install_outcome === "success") { | ||
| // Update store with installation completion and logs |
| name: diskName, | ||
| sizePretty: this._installDisks[this._selected_disk_index].sizePretty | ||
| }, | ||
| logs: this._logs |
Contributor
There was a problem hiding this comment.
weird indentation here
Contributor
|
I think storing this as an ephemeral variable inside dogeboxd that is returned in the recovery bootstrap is a better place to store this, rather than the frontend? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues being addressed here: