build: pin attw + override fflate to fix integrity-checks#6
Merged
Conversation
`npm run integrity-checks` (and so `prepublishOnly`) was crashing in the `attw` step with `Cannot read properties of undefined (reading 'filename')`. Root cause: fflate 0.8.3 (released 2026-05-16) broke `@arethetypeswrong/core`'s tarball decompression — its `Gunzip` shim only ever captures the last chunk, and the new fflate emits more than one for our tarball. - Pin `@arethetypeswrong/cli@0.18.2` as a devDependency so the attw binary is locked alongside its transitive deps. - `overrides.fflate = "0.8.2"` to roll the bad transitive back. - Drop the `npx` from the `attw` script — we have a local copy now. Verified: `npm run integrity-checks` is green again (attw reports 🟢 on node10 / node16 / bundler). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
Oof, I'd already done this on the Todoist SDK and never even thought about fixing it for Twist (which will still need this fix as well). |
doistbot
reviewed
May 21, 2026
Member
doistbot
left a comment
There was a problem hiding this comment.
Thank you for quickly addressing the build failure during integrity checks by pinning the @arethetypeswrong/cli dependency and overriding the broken fflate transitive dependency. These adjustments effectively restore the reliability of the prepublish pipeline. It was noted that scoping the fflate override specifically to the affected tool, rather than applying it globally, would prevent unintended constraints on future dependencies.
scottlovegrove
added a commit
to Doist/twist-sdk-typescript
that referenced
this pull request
May 22, 2026
## Context `npm run integrity-checks` (and so `prepublishOnly`) was crashing in the `attw` step with `Cannot read properties of undefined (reading 'filename')`. Root cause: fflate 0.8.3 broke `@arethetypeswrong/core`'s tarball decompression — its `Gunzip` shim only captures the last chunk, and the new fflate emits more than one for our tarball. Same fix as Doist/comms-sdk-typescript#6. ## What was changed - Pin `@arethetypeswrong/cli@0.18.2` as a devDependency so the attw binary is locked alongside its transitive deps. - `overrides.fflate = "0.8.2"` to roll the bad transitive back. - Drop the `npx` from the `attw` script — we have a local copy now. ## Verified `npm run attw` green again. attw reports 🟢 on node10 / node16 (CJS+ESM) / bundler. `fflate@0.8.2 overridden` confirmed via `npm ls fflate`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
npm run integrity-checks(and soprepublishOnly) was crashing in theattwstep withCannot read properties of undefined (reading 'filename').Root cause: fflate 0.8.3 (released 2026-05-16) broke
@arethetypeswrong/core's tarball decompression — itsGunzipshim only captures the last chunk, and the new fflate emits more than one for our tarball.What was changed
@arethetypeswrong/cli@0.18.2as a devDependency so the attw binary is locked alongside its transitive deps.overrides.fflate = "0.8.2"to roll the bad transitive back.npxfrom theattwscript — we have a local copy now.Verified
npm run integrity-checksgreen again. attw reports 🟢 on node10 / node16 (CJS+ESM) / bundler.