Skip to content

build(deps): refresh dependencies and React peer support#60

Merged
gnapse merged 1 commit into
nextfrom
ernesto/update-current-dependencies
May 22, 2026
Merged

build(deps): refresh dependencies and React peer support#60
gnapse merged 1 commit into
nextfrom
ernesto/update-current-dependencies

Conversation

@gnapse
Copy link
Copy Markdown

@gnapse gnapse commented May 22, 2026

Summary

  • refresh direct dev dependencies and regenerate the lockfile, including the React 18.3.1 local baseline, TypeScript 6, and current linting/testing packages
  • add explicit @testing-library/dom and @types/node so npm ci --legacy-peer-deps resolves the same way as local installs
  • keep consumer compatibility centered on Todoist Web by making react the only peer dependency with a ^18.0.0 || ^19.0.0 range and dropping react-dom from peers
  • keep the runtime code compatible with newer React typings by narrowing React.isValidElement in src/interpolate.tsx

Validation

  • npm ci --legacy-peer-deps
  • npm run check
  • npm test
  • npm run build

@gnapse gnapse self-assigned this May 22, 2026
@gnapse gnapse marked this pull request as ready for review May 22, 2026 15:04
@gnapse gnapse requested review from a team and rmartins90 and removed request for a team May 22, 2026 15:05
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR refreshes the repository's direct development dependencies and updates the React peer dependency range to target versions 18 and 19. These updates are a great step toward keeping the project aligned with modern ecosystem standards and ensuring smoother local installations. However, the proposed changes alter the published contract by dropping React 17 support and widening to React 19 without corresponding CI coverage, which introduces the risk of resolution failures for existing consumers and untested regressions.

Share FeedbackReview Logs

Comment thread package.json
Comment thread package.json
@gnapse gnapse merged commit 0149eb0 into next May 22, 2026
2 checks passed
@gnapse gnapse deleted the ernesto/update-current-dependencies branch May 22, 2026 15:16
@rmartins90
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants