Skip to content

feat!: remove brand-coloured defaults from token vars #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmjabreu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat!: remove brand-coloured defaults from token vars #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a181367
feat!: remove brand-coloured defaults from token vars
lmjabreu May 20, 2026
7d4cb6b
Merge remote-tracking branch 'origin/main' into chore/remove-brand-de…
lmjabreu May 21, 2026
7e05e8a
fix: narrow scope to audit Q5 (revert button + design-tokens over-rea…
lmjabreu May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/progress-bar/progress-bar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
--reactist-progressbar-radius-outer: var(--reactist-progressbar-height);
--reactist-progressbar-radius-inner: var(--reactist-progressbar-height);
--reactist-progressbar-track: var(--reactist-framework-fill-crest);
--reactist-progressbar-fill: var(--reactist-bg-brand);
--reactist-progressbar-fill: currentColor;
--reactist-progressbar-scale-tint: var(--reactist-content-tertiary);
--reactist-progressbar-scale-tick-height: 8px;
--reactist-progressbar-scale-minor-tick-opacity: 0.15;
Expand Down
2 changes: 1 addition & 1 deletion src/spinner/spinner.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
:root {
--reactist-spinner-tint: var(--reactist-bg-brand);
--reactist-spinner-tint: currentColor;
--reactist-spinner-fill: var(--reactist-framework-fill-crest);
}

Expand Down
43 changes: 0 additions & 43 deletions src/styles/design-tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@

/* background color */
--reactist-bg-default: rgb(255, 255, 255);
--reactist-bg-brand: rgb(36, 111, 224);
Copy link
Copy Markdown
Contributor

@pawelgrimm pawelgrimm May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with the overall direction of this PR. The defaults we provide in this library are expected to be configured by consumers, after all, that's how we inject themes (e.g. in Todoist) into these component.

I'm okay with deprecating certain tokens, like --reactist-bg-brand and using something more like --reactist-actionable-primary-idle-fill as the default for something like --reactist-progressbar-fill.

Removing all of these tokens removes some of the colors in the storybook, which is undesirable — we do want to indicate that those colored components are customizable.

--reactist-bg-aside: rgb(250, 250, 250);
--reactist-bg-highlight: rgb(242, 242, 242);
--reactist-bg-selected: rgb(230, 230, 230);
Expand All @@ -90,43 +89,6 @@

/* component-specific */

/* actionable colors */
--reactist-actionable-primary-idle-tint: #ffffff;
--reactist-actionable-primary-idle-fill: #008aa6;
--reactist-actionable-primary-hover-tint: #ffffff;
--reactist-actionable-primary-hover-fill: #007992;
--reactist-actionable-primary-disabled-tint: #ffffff;
--reactist-actionable-primary-disabled-fill: #99d0db;

--reactist-actionable-secondary-idle-tint: #282f30;
--reactist-actionable-secondary-idle-fill: #f2f6f7;
--reactist-actionable-secondary-hover-tint: #282f30;
--reactist-actionable-secondary-hover-fill: #e3e7e8;
--reactist-actionable-secondary-disabled-tint: #a9acac;
--reactist-actionable-secondary-disabled-fill: #f2f6f7;

--reactist-actionable-tertiary-idle-tint: #006f85;
--reactist-actionable-tertiary-hover-tint: #006f85;
--reactist-actionable-tertiary-hover-fill: #f2f6f7;
--reactist-actionable-tertiary-disabled-tint: #99c5ce;

--reactist-actionable-quaternary-idle-tint: #6c777a;
--reactist-actionable-quaternary-hover-tint: #282f30;
--reactist-actionable-quaternary-hover-fill: #e0e7e8;
--reactist-actionable-quaternary-disabled-tint: #c4c9ca;

--reactist-actionable-primary-destructive-idle-tint: #ffffff;
--reactist-actionable-primary-destructive-idle-fill: #dc4c3e;
--reactist-actionable-primary-destructive-hover-tint: #ffffff;
--reactist-actionable-primary-destructive-hover-fill: #b03d32;
--reactist-actionable-primary-destructive-disabled-tint: #ffffff;
--reactist-actionable-primary-destructive-disabled-fill: #f1b7b2;

--reactist-actionable-secondary-destructive-idle-tint: #dc4c3e;
--reactist-actionable-secondary-destructive-hover-tint: #b03d32;
--reactist-actionable-secondary-destructive-hover-fill: transparent;
--reactist-actionable-secondary-destructive-disabled-tint: #f1b7b2;

/* alerts */
--reactist-alert-tone-info-icon: rgba(49, 111, 234);
--reactist-alert-tone-info-border: rgba(238, 238, 238);
Expand All @@ -147,11 +109,6 @@
/* fields */
--reactist-field-readonly-background: rgb(246, 244, 244);

/* switches and checkboxes */
--reactist-switch-background: var(--reactist-framework-fill-summit);
--reactist-switch-checked: var(--reactist-content-positive);
--reactist-switch-toggle: var(--reactist-bg-default);

/* toasts */
--reactist-toast-actionable-primary-tint: #39d1ef;
--reactist-toast-actionable-secondary-tint: #b6c1c3;
Expand Down
Loading