Fix hooks.json schema: nest matcher commands under "hooks" array#3
Open
takekaraka wants to merge 1 commit into
Open
Fix hooks.json schema: nest matcher commands under "hooks" array#3takekaraka wants to merge 1 commit into
takekaraka wants to merge 1 commit into
Conversation
Each PreToolUse/PostToolUse matcher entry placed type/command/timeout directly on the matcher object. The Claude Code hooks schema requires those nested inside a per-matcher "hooks" array, so validation failed with "expected array, received undefined" and none of the plugin hooks loaded. Wraps all four matcher entries (2 PreToolUse, 2 PostToolUse) in the required "hooks" array. No behavior change beyond the hooks now loading. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![dojo-code-reviewer[bot]](https://avatars.githubusercontent.com/in/3092887?s=60&v=4){kind=small}
|
+1 please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
Problem
Claude Code
/doctorreports a hook load failure and none of the plugin hooks load:Each matcher entry in
hooks/hooks.jsonplacedtype/command/timeoutdirectly on the matcher object. The Claude Code hooks schema requires those nested inside a per-matcherhooksarray.Fix
Wraps all four matcher entries (2
PreToolUse, 2PostToolUse) in the requiredhooksarray. JSON validated. No behavior change beyond the hooks now actually loading.Before:
{ "matcher": "...", "type": "command", "command": "...", "timeout": 5000 }After:
{ "matcher": "...", "hooks": [ { "type": "command", "command": "...", "timeout": 5000 } ] }