Reef chain - #776
Conversation
|
Automated template check 🤖 This PR's template was imported into a test Dokploy instance (using the Result: ❌ some issues need attention
|
# Conflicts: # meta.json
…gen) Remove reef-bootnode, reef-rpc, reef-validator, reef-spec-gen, reef-eth-rpc and reef-faucet: their defaults depend on external infrastructure (*.reef.host / 72.60.35.83) that is offline, or on manually wiring values between deployments, so they cannot work as one-click templates. reef-dev-cluster and reef-keygen are fully self-contained and verified working. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for the contribution — and for your patience on this one. I re-tested all 8 templates on a clean Dokploy instance and did a scope review. Summary below. Test results (fresh deploys, defaults only)
Scope decisionDokploy templates need to work one-click with their defaults. Six of the eight templates form a multi-VPS "build your own network" kit that requires manual cross-deployment wiring (keygen → bootnode → spec URL → validators/RPC), and their defaults point at personal infrastructure ( Since maintainer edits are allowed on this PR, I've reduced it to the subset that genuinely works out of the box:
Also pushed: merge of latest One note for users of Verified: @anukulpandey is a Reef core contributor (member of the reef-chain org with 1k+ commits there); the |
What is this PR about?
New PR of Reef Chain
This PR updates the Reef Chain templates to the new
stable2512deployment flow and switches all runtime-fetched scripts to the dedicated scripts repository:https://github.com/anukulpandey/dokploy-reef-chain-scriptsIncluded changes
reef-bootnodeto fetch bootstrap/runtime scripts from the new scripts reporeef-validatorto fetch the validator startup script from the new scripts reporeef-rpcto fetch the RPC startup script from the new scripts reporeef-spec-gento fetch the spec generator API and helper scripts from the new scripts reporeef-dev-clusterto stop downloading the old Makefile-based workflow and instead use the new non-tmuxcluster launcher script8545inreef-dev-clusterfor bundledeth-rpcreef-faucettemplatemeta.jsonreef-dokploy-templates-v2raw GitHub pathsWhy this change
This aligns the Reef templates with the newer
stable2512chain workflow and centralizes all runtime scripts in a single dedicated repository so Dokploy services fetch a stable, maintained source at startup.Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
Close automatically the related issues using the keywords:
closes #ISSUE_NUMBERScreenshots or Videos
N/A
Greptile Summary
This PR updates all Reef Chain templates to the
stable2512workflow, centralizes runtime scripts in a dedicated external repository, and adds a newreef-faucettemplate. Several structural issues conflict with the project's Docker Compose conventions documented in AGENTS.md and need to be addressed before merging:portsinstead of the requiredexpose, missingrestartpolicy, and most lack the requiredversion: \"3.8\"header.reef-spec-genservice is namedreef-spec-api, breaking the mandatory folder-name match and the domain config in itstemplate.toml.template.tomlfiles hardcode the same validator private-key seeds as default values (includingFAUCET_SEED), violating the "never hardcode secrets" rule.mainbranch of an external repo without hash verification, creating a supply-chain risk.Confidence Score: 3/5
Not safe to merge — multiple P1 violations of documented Dokploy conventions, a service naming mismatch that breaks domain routing, hardcoded validator private-key seeds, and unpinned external script downloads creating supply-chain exposure.
Five P1 findings are present: (1) all templates use
portsinstead of the mandatoryexpose, (2) none have arestartpolicy, (3) five templates omitversion: "3.8"and one uses "3.9", (4) thereef-spec-genservice name mismatch will break its domain config, and (5) hardcoded default private-key seeds across four templates violate the no-secrets rule and introduce a real security risk on any default deployment.All
docker-compose.ymlfiles (ports/restart/version),blueprints/reef-spec-gen/docker-compose.yml(service name), and alltemplate.tomlfiles that hardcode seed values (reef-bootnode,reef-dev-cluster,reef-validator,reef-faucet).Vulnerabilities
reef-bootnode,reef-dev-cluster,reef-validator, andreef-faucetall ship the same three validator seeds as defaulttemplate.tomlvalues. A default deployment controls a live chain with publicly-known signing keys and a known faucet treasury key.anukulpandey/dokploy-reef-chain-scriptson themainbranch at startup with no checksum validation. A compromised or modified push to that repo will silently affect all running deployments on next restart.Reviews (1): Last reviewed commit: "Wire Reef templates to external scripts ..." | Re-trigger Greptile
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
Context used: