This repository was archived by the owner on Aug 22, 2024. It is now read-only.
Open
Conversation
Luuc15
suggested changes
Jun 26, 2018
Contributor
Luuc15
left a comment
There was a problem hiding this comment.
These changes use an attribute to be the field that defines the fields that have files that have to be emailed. It would be better to use a method for this so the attributes will always relate to a field.
Like a getUploadedFiles function. You can even let this function just loop all fields to check if it is an upload field.
Also the foreach loop reading all file fields uses attachContent function as if we can only upload one file per field. It would be better to be able process multi-fileupload as wel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to attach files to their forms and email them to the owner.
public $files = [];on the model to define files that should be attached.UploadedFileobject foreach$fileson modelattachContentonownerMailto get file content and attach it to the email.errorsto the response of the form to return submission validation errors.