Skip to content

fix: results labeling#9

Merged
vladisl0th merged 2 commits into
mainfrom
master
Mar 23, 2026
Merged

fix: results labeling#9
vladisl0th merged 2 commits into
mainfrom
master

Conversation

@vladisl0th
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Owner

@Don-Yin Don-Yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to use the benchmark series name instead of hardcoding "SPX". however, line 272 has a diff artifact left in the code:

      272 +     axes[5].plot(common, b_rebased, label=bm_label, linewidth=1,

the 272 + is not valid Python and will cause a SyntaxError at runtime. please fix the indentation to match the surrounding lines:

                bm_label = benchmark.name if benchmark.name else "benchmark"
                axes[5].plot(common, b_rebased, label=bm_label, linewidth=1,

once that is fixed this is good to merge.

@vladisl0th vladisl0th merged commit b5bd6fb into main Mar 23, 2026
3 checks passed
Copy link
Copy Markdown
Owner

@Don-Yin Don-Yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks vlad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants