Feat/ram efficient xdmf archiving - #75
Merged
Merged
Conversation
DonsetPG
approved these changes
Mar 24, 2026
vincentlannelongue
added a commit
that referenced
this pull request
Apr 23, 2026
* Add xdmf append function and update lightning module * Add tests for lightining module and meshiomesh and remove compress parameter * Add lxml requirement to CI/CD * Add compression parameter in lightning module * Rename compression parameter * Update readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation and prediction in LightningModule was done by generating all predictions to save the XDMF/HDF5 archive at the end. When working with large simulations, memory can become a limitation.
The prediction and validation batches are now added to the archive files on the go and there is no need to store the whole predicted simulation in the memory. This also comes with a faster compressing time for same compression level. When lowering compression settings in HDF5 data, speed can be further increased.