Skip to content

Fix Friflo SystemWithThreeComponents bug #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Doraku merged 1 commit into from
Feb 20, 2025
Merged

Fix Friflo SystemWithThreeComponents bug #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions source/Ecs.CSharp.Benchmark/SystemWithThreeComponents/FrifloEngineEcs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void FrifloEngineEcs_MultiThread()

private static void Update(ref Component1 c1, ref Component2 c2, ref Component3 c3)
{
c1.Value = c2.Value + c3.Value;
c1.Value += c2.Value + c3.Value;
}

[BenchmarkCategory(Categories.FrifloEngineEcs)]
Expand All @@ -72,10 +72,12 @@ public void FrifloEngineEcs_SIMD_MonoThread()
int step = component1.StepSpan256; // step = 8
for (int n = 0; n < component1Span.Length; n += step)
{
Vector256<int> value1 = Vector256.Create<int>(component1Span.Slice(n, step));
Span<int> component1Slice = component1Span.Slice(n, step);
Vector256<int> value1 = Vector256.Create<int>(component1Span);
Vector256<int> value2 = Vector256.Create<int>(component2Span.Slice(n, step));
Vector256<int> result = Vector256.Add(value1, value2); // execute 8 add instructions at once
result.CopyTo(component3Span.Slice(n, step));
Vector256<int> value3 = Vector256.Create<int>(component3Span.Slice(n, step));
Vector256<int> result = Vector256.Add(value1, Vector256.Add(value2, value3)); // execute 16 add instructions
result.CopyTo(component1Slice);
}
}
}
Expand Down