Conversation
geonnave
left a comment
There was a problem hiding this comment.
Thanks for this PR!
Could you add a very basic README to each new example folder explaining:
- what it does
- how to run it (and specific dependencies to install, if applicable)
|
I've added a README for the two examples and removed optional dependencies from pyproject.toml. The dependencies are now mentioned in each of the example's README |
aabadie
left a comment
There was a problem hiding this comment.
I only have comestic comments. I'll try to test your PR later today.
|
Also the CI is complaining because of code formatting issues. Install and run black to solve the problems. |
|
Some of my comments above are still not addressed (the ones about the missing newline at end of file) |
|
Sorry for the missed lines. I've fixed the lines at the end for the remaining files |
b06a858 to
e963eeb
Compare
|
FYI I allowed myself to apply some changes to fix the lint issues and missing dependencies reported by the CI. The tests are now launched correctly but an unrelated one is still failing. I'm investigating. Once the CI is green I'll merge this PR. |
45ecc34 to
b5477e3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
===========================================
- Coverage 81.99% 68.84% -13.15%
===========================================
Files 30 40 +10
Lines 2943 3739 +796
===========================================
+ Hits 2413 2574 +161
- Misses 530 1165 +635 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b985c5 to
2618d69
Compare
548b8d7 to
7883c03
Compare
|
I finally found the issue which is indeed not related but I fixed it here. So let's go! |
Adding two examples for the PyDotBot.
1. Minimum naming game (with and without motion): From a list of potential words, a swarm of DotBots runs a distributed algorithm to agree on a single word using local communication.
2. Work and charge: A swarm of DotBots alternate moving between a work region to perform work and a charge region to recharge.