Skip to content

Controller: allow overriding value of binary flags#211

Merged
aabadie merged 2 commits intoDotBots:mainfrom
geonnave:allow-override-flags
Feb 26, 2026
Merged

Controller: allow overriding value of binary flags#211
aabadie merged 2 commits intoDotBots:mainfrom
geonnave:allow-override-flags

Conversation

@geonnave
Copy link
Contributor

Allows passing e.g. --no-webbrowser and override a webbrowser = true config from a toml config file.
Doing that was not possible with click's is_flag=True.

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.84%. Comparing base (7883c03) to head (24f313d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   68.84%   68.84%           
=======================================
  Files          40       40           
  Lines        3739     3739           
=======================================
  Hits         2574     2574           
  Misses       1165     1165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aabadie
Copy link
Contributor

aabadie commented Feb 24, 2026

Can you fix the broken test?

@aabadie aabadie force-pushed the allow-override-flags branch from 1a5778f to 24f313d Compare February 26, 2026 05:52
@aabadie aabadie merged commit b39c9d3 into DotBots:main Feb 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants