Skip to content

feat: enhance dry run diff view to show friendly names (resolves #51)#53

Open
Tiya22gif wants to merge 1 commit into
DotDev262:mainfrom
Tiya22gif:feature/issue-51-enhanced-diff
Open

feat: enhance dry run diff view to show friendly names (resolves #51)#53
Tiya22gif wants to merge 1 commit into
DotDev262:mainfrom
Tiya22gif:feature/issue-51-enhanced-diff

Conversation

@Tiya22gif
Copy link
Copy Markdown

@Tiya22gif Tiya22gif commented May 16, 2026

Related Issue

Closes #51

Proposed Changes

  • Updated Engine.PrintDiffAsync to use a newly implemented FormatFriendlyName helper.
  • Implemented GetFriendlyName in SystemSettingsService and ISystemSettingsService to resolve raw registry paths into friendly internal catalog keys (e.g., dark_mode, taskbar_alignment).
  • Formatted App Package Manager strings into friendly formats like App (winget): vscode.
  • Updated failing unit tests in EngineTest.cs to match the newly implemented friendly string formats.

Example output now shows:

  • System Setting: show_file_extensions
  • App (scoop): git
  • Registry Tweak: HKCU\Software\WinHomeTest -> TestValue

I also updated the existing unit tests to validate the new diff output formatting.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 📖 Documentation
  • 🧪 Testing
  • 🛠️ Refactoring
  • 🚀 DevOps/CI

Screenshots / Logs (if applicable)

Testing & Verification

  • [✅] I have run dotnet test and all 60+ cross-platform tests passed.
  • [✅] I have verified the changes on a Windows environment (if applicable).
  • [] I have added new unit tests to cover my changes.

GSSOC 2026 Checklist

  • [✅] I have read the Contribution Guidelines.
  • [✅] My code is formatted correctly (I have run dotnet format).
  • [✅] I have linked the PR to an approved issue.
  • [✅] I understand that a maintainer must apply the gssoc:approved label for this PR to count for points.

@DotDev262 DotDev262 added GSSOC GirlScript Summer of Code 2026 gssoc:approved Approved for GSSOC points (Required) labels May 16, 2026
@DotDev262 DotDev262 self-assigned this May 16, 2026
@DotDev262
Copy link
Copy Markdown
Owner

I need a screenshot of the execution of the diff function , and it seems you have edited the unit test but didn't mark it in the pull request

@Tiya22gif
Copy link
Copy Markdown
Author

Thanks for the review @DotDev262 !
Screenshot 2026-05-17 010056

I’ll add a screenshot/log of the --diff execution output to demonstrate the updated human-readable formatting.

You’re also correct about the unit tests — I updated the existing tests to match the new friendly-name output format, but I forgot to explicitly mention that in the PR checklist/comment. I’ll update the PR description to reflect the test modifications clearly.

@DotDev262
Copy link
Copy Markdown
Owner

The screenshot is not the output of the diff function rather its the dotnet build

@Tiya22gif
Copy link
Copy Markdown
Author

Okay, please give me some time @DotDev262. I hadn’t taken screenshots earlier, so I need to re-run and verify the diff output again.

After that, I’ll upload all the required screenshots/logs and update the PR details accordingly.

@DotDev262 DotDev262 self-requested a review May 18, 2026 09:10
@DotDev262
Copy link
Copy Markdown
Owner

Any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSOC points (Required) GSSOC GirlScript Summer of Code 2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logic] Enhanced Dry Run Diff View

2 participants