Fix math in getExperienceForTotalLevel for levels between 16 and 30#458
Open
Jabberdrake wants to merge 1 commit into
Open
Fix math in getExperienceForTotalLevel for levels between 16 and 30#458Jabberdrake wants to merge 1 commit into
Jabberdrake wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Minecraft Wiki, the formula we can use to calculate the amount of experience needed to go from level 0 to x, for any x between 16 and 30 is: 2.5x^2 - 40.5x + 360.
To avoid dealing with float math, the mod multiplies the whole expression by 2, then divides the result by 2 and simplifies wherever possible. The problem is that while calculating the new expression, the 40.5x term turned into 91x instead of 81x. This PR corrects that mistake.