perf: limit rsi signal to trailing window#8
Open
christianarriaga1234-coder wants to merge 1 commit into
Open
Conversation
|
@christianarriaga1234-coder is attempting to deploy a commit to the dragoon4002's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #2.
This PR removes unnecessary full-history work from
rsi_signal. The RSI calculation only needs the latestperiodprice changes, so the function now scans just that trailing window instead of walking every price on each call and then slicing back to the same lastperiodvalues.Type
Changes
rsi_signalgain/loss accumulation toprices[-period-1:]semantics.Benchmark
Synthetic 10,000-price input, 20,000 calls, direct Python runtime:
69.610807s0.124175s560.59xThe output equality assertion passed before timing.
Testing
python -m py_compile app/strategies/quant_algos/mean_reversion_algos.py shared/tests/test_mean_reversion_algos.pygit diff --checkChecklist