Skip to content

Clarify visible-page semantics - #15

Merged
Driedsandwich merged 1 commit into
mainfrom
codex/f004-visible-semantics
Aug 14, 2026
Merged

Clarify visible-page semantics#15
Driedsandwich merged 1 commit into
mainfrom
codex/f004-visible-semantics

Conversation

@Driedsandwich

Copy link
Copy Markdown
Owner

Summary

  • define visible-page content as CSS-rendered or potentially visible
  • document the hidden/inert, display, visibility, and opacity exclusions
  • state that viewport presence, lack of occlusion, and current on-screen presence are not guaranteed
  • keep viewport clipping, IntersectionObserver checks, and occlusion detection outside the runtime design

Closes #14

Scope

This PR addresses GPTPro re-audit finding F004 only. F003, runtime extraction, permissions, dependencies, workflows, releases, and packaging are unchanged.

Verification

  • bundled Node test — 40/40 passed
  • repository sanity static checks — passed
  • git diff --check — passed
  • docs truth search — rendered/potential visibility and viewport/occlusion limitations present
  • security triage — docs-only two-file diff; no runtime, manifest, workflow, package, permission, or communication-path changes

Boundaries

  • no IntersectionObserver, viewport clipping, or occlusion detection
  • no F003 changes
  • Draft and unmerged pending maintainer review

@Driedsandwich
Driedsandwich marked this pull request as ready for review August 14, 2026 04:15
@Driedsandwich
Driedsandwich merged commit 639031e into main Aug 14, 2026
1 check passed
@Driedsandwich
Driedsandwich deleted the codex/f004-visible-semantics branch August 14, 2026 04:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 109a898840

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
Comment on lines +31 to +33
Here, visible means CSS-rendered or potentially visible. The extractor excludes
content hidden by `hidden` or `inert`, `display: none`, hidden or collapsed
visibility, or zero opacity. It does not guarantee that extracted content is

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify the descendant visibility guarantee

When a rendered body or comment contains a nested opacity: 0 or [inert] element, isVisiblyRendered checks only the extraction root and its ancestors before reading the root's complete innerText; opacity and inert do not remove that descendant text from innerText. The new wording therefore promises an exclusion the implementation does not enforce. Either limit the claim to body/comment extraction roots and their ancestors or filter hidden descendants before export.

AGENTS.md reference: AGENTS.md:L62-L73

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Clarify visible-page semantics

1 participant