Canonicalize exported source URLs - #8
Conversation
8211ee6 to
7714946
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 771494658a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Issue or Pull Request number | ||
| - page type | ||
| - source URL | ||
| - canonical source URL without query parameters or fragments |
There was a problem hiding this comment.
Align the manual checks with canonical URL export
When verifying a page opened with query parameters or a fragment, the manual guide and result template still require the “current ... page URL,” so they neither describe nor test the new requirement that those components be removed. Update docs/07_manual_verification.md and docs/08_manual_verification_result_template.md to require the canonical URL and include a query/fragment case; otherwise the repository's prescribed verification can pass without exercising this behavior.
AGENTS.md reference: AGENTS.md:L58-L60
Useful? React with 👍 / 👎.
Summary
Related Issue and acceptance criteria
https://github.com/<owner>/<repo>/<type>/<number>form; query and fragment data are absent.Changes
Verification
npm test— 38/38 passed771494658a89070ef40db6c3f9921d20227dd5eb31761276039— success49f97ce3-38e5-4a83-b626-b525b148b3bb— finding 0Risk review
activeTab,scripting,clipboardWrite, with no host permissionsScope check