Skip to content

Canonicalize exported source URLs - #8

Merged
Driedsandwich merged 1 commit into
mainfrom
codex/issue-7-canonical-url
Aug 14, 2026
Merged

Canonicalize exported source URLs#8
Driedsandwich merged 1 commit into
mainfrom
codex/issue-7-canonical-url

Conversation

@Driedsandwich

@Driedsandwich Driedsandwich commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Export canonical GitHub Issue and Pull Request source URLs.
  • Drop incidental query parameters and fragments from the generated Markdown.
  • Preserve the existing visible-page-only, local-first, read-only boundary.

Related Issue and acceptance criteria

  • Issue: Closes [Privacy] Canonicalize exported source URLs #7
  • Acceptance criteria: supported Issue and Pull Request URLs contain only the canonical https://github.com/<owner>/<repo>/<type>/<number> form; query and fragment data are absent.

Changes

  • Reconstruct the source URL from the already-validated Issue/PR pathname inside the self-contained injected extractor.
  • Add Issue and Pull Request regressions with query and fragment inputs.
  • Align public documentation with the canonical URL contract.

Verification

  • npm test — 38/38 passed
  • Manual verification completed against exact head 771494658a89070ef40db6c3f9921d20227dd5eb
  • Exact-head sanity run 31761276039 — success
  • Gitleaks 8.30.1 exact tree and introduced range — finding 0
  • Codex Security exact diff scan 49f97ce3-38e5-4a83-b626-b525b148b3bb — finding 0
  • Isolated headed Chrome for Testing 151: exact-head single PASS receipt for a public-safe Issue, Pull Request Conversation, unsupported page, Copy, Download, and permissions; query and fragment inputs produced canonical source URLs

Risk review

  • Permission impact: none; remains activeTab, scripting, clipboardWrite, with no host permissions
  • Privacy impact: removes incidental navigation metadata from exports
  • Dependency impact: none
  • Network or external-communication impact: none; no API or external transmission added

Scope check

  • No unrelated refactor or formatting changes
  • No credentials, private content, personal data, or private screenshots
  • Documentation updated or an explicit reason given
  • No new completeness, production-readiness, or security-scanner claim

@Driedsandwich
Driedsandwich force-pushed the codex/issue-7-canonical-url branch from 8211ee6 to 7714946 Compare August 14, 2026 01:39
@Driedsandwich
Driedsandwich marked this pull request as ready for review August 14, 2026 01:47
@Driedsandwich
Driedsandwich merged commit bc58d62 into main Aug 14, 2026
1 check passed
@Driedsandwich
Driedsandwich deleted the codex/issue-7-canonical-url branch August 14, 2026 01:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 771494658a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/01_requirements.md
- Issue or Pull Request number
- page type
- source URL
- canonical source URL without query parameters or fragments

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the manual checks with canonical URL export

When verifying a page opened with query parameters or a fragment, the manual guide and result template still require the “current ... page URL,” so they neither describe nor test the new requirement that those components be removed. Update docs/07_manual_verification.md and docs/08_manual_verification_result_template.md to require the canonical URL and include a query/fragment case; otherwise the repository's prescribed verification can pass without exercising this behavior.

AGENTS.md reference: AGENTS.md:L58-L60

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Privacy] Canonicalize exported source URLs

1 participant