Open
Conversation
gracia10
requested changes
May 22, 2023
Member
There was a problem hiding this comment.
에러 메세지를 명확하게 하면 좋을것 같아요
다음 뉴스 사이트 장애로 뉴스기사가 조회가 안된건지 -> 이러면 우리 책임 아님
뉴스 기사가 한건도 없어서 발생한 건지 -> 에러상황이 아니니 error 보단 info가 좋을것 같습니다
크롤링은 상대서버에 따라 실패하는 경우가 많아서
테케를 하나 만드는 것도 좋을것 같습니다
Member
Author
There was a problem hiding this comment.
피드백 감사합니다! 추후 테스트코드와 함께 에러메시지를 수정하도록 하겠습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
주요 변경 사항
시급한 정도
🐢 급하지 않습니다. 천천히 리뷰해주시면 감사하겠습니다.
중점적으로 봐주었으면 하는 부분