New design: /positions#1170
Conversation
Tomas-Ka
left a comment
Tomas-Ka
left a comment
There was a problem hiding this comment.
looks overall good, needs some comments removed, I have some questions about why you use bytes instead of strings for the uuid, permission checks server side (I know we have them client side), and some other small things
Tomas-Ka
left a comment
Tomas-Ka
left a comment
There was a problem hiding this comment.
I didn't have time to finish a review of the design when I was working on this last, but I feel there is a little to work on there, particularly as it seems to be a direct implementation of the old page instead of being incorporated into the new design. Afaik there isn't a design for this page in figma, but would it be possible to fit it more into the design of the new page?
Will do a proper design review at some point today.
|
Can also mention your new commits all look good |
fgren
force-pushed
the
new-design-positions
branch
from
a3b488a to
310973c
Compare
Tomas-Ka
left a comment
Tomas-Ka
left a comment
There was a problem hiding this comment.
Please update the design of the position page to more accurately reflect our new design. The code looks great, but the design needs some work.
| {/if} | ||
|
|
||
| <!-- Edit modal --> | ||
| {#if isEditing}<div |
There was a problem hiding this comment.
It would be good if this popup were to disappear when you click away from it
fgren
force-pushed
the
new-design-positions
branch
2 times, most recently
from
ddf1409 to
71de145
Compare
fgren
force-pushed
the
new-design-positions
branch
from
71de145 to
38e2ec7
Compare
|
is this ready for review again? |
yes |
2 participants
🧩 Summary
Adds the /position/[id] pages, complete with mandate editing
🔗 Related issues (if any)
Closes #1163
📸 Screenshots / recordings (if applicable)
💬 Other information
Also does tweaks to the date picker and member selector to make them easier to use.