Add a script && workflow to check translation synchronisation#1192
Conversation
i forgot to account for the fact that we're using javascript |
Tomas-Ka
left a comment
There was a problem hiding this comment.
Script looks great. Just a few things about the removed translation files.
Also, if you could add an entry to the package.json to allow running the translation check with pnpm translation-check or similar that would be great
For example by adding this:
"translation-check": "./dev/check_translations.sh" This could be added to theci-check` action as well, in which case we wouldn't need a separate workflow for it as it would already run in the existing one.
|
well fuck |
|
I'll add it to |
|
I've added it to |
Tomas-Ka
left a comment
There was a problem hiding this comment.
I would like to have the new check-translations action in the general pnpm action for CI. After looking more closely at it I think it's reasonable to let this be it's own worker (instead of bundling it with everything else). I mostly pushed to consolidate since I believed the workflow used the pnpm ci-check command already
|
I did not add |
Tomas-Ka
left a comment
There was a problem hiding this comment.
this looks great, tyvm!
🧩 Summary
Adds a script && workflow to check translation synchronisation
🔗 Related issues (if any)
Closes #1187
💬 Other information
This adds a script to the
devdirectory. This made writing the workflow easier and as a side effect made the check easier to do locally.I also removed the translation strings that only existed in one language. I do not think this will pose a problem since they were unusable anyway.