Skip to content

Add a script && workflow to check translation synchronisation#1192

Merged
SLUCHABLUB merged 5 commits into
new-designfrom
new-design-translation-key-diff
May 21, 2026
Merged

Add a script && workflow to check translation synchronisation#1192
SLUCHABLUB merged 5 commits into
new-designfrom
new-design-translation-key-diff

Conversation

@SLUCHABLUB
Copy link
Copy Markdown
Contributor

🧩 Summary

Adds a script && workflow to check translation synchronisation

🔗 Related issues (if any)

Closes #1187

💬 Other information

This adds a script to the dev directory. This made writing the workflow easier and as a side effect made the check easier to do locally.

I also removed the translation strings that only existed in one language. I do not think this will pose a problem since they were unusable anyway.

@SLUCHABLUB
Copy link
Copy Markdown
Contributor Author

since they were unusable anyway

i forgot to account for the fact that we're using javascript

Copy link
Copy Markdown
Contributor

@Tomas-Ka Tomas-Ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script looks great. Just a few things about the removed translation files.
Also, if you could add an entry to the package.json to allow running the translation check with pnpm translation-check or similar that would be great
For example by adding this:
"translation-check": "./dev/check_translations.sh" This could be added to theci-check` action as well, in which case we wouldn't need a separate workflow for it as it would already run in the existing one.

Comment thread dev/check_translations.sh
Comment thread src/translations/sv.json
Comment thread src/translations/sv.json
Comment thread src/translations/sv.json
Comment thread src/translations/sv.json
@Tomas-Ka
Copy link
Copy Markdown
Contributor

well fuck
bad timing

@SLUCHABLUB
Copy link
Copy Markdown
Contributor Author

I'll add it to package.json as well.

@SLUCHABLUB
Copy link
Copy Markdown
Contributor Author

I've added it to package.json and moved the check into the existing CI workflow. I guess I thought it would be cleaner with a separate workflow but in hindsight, this is probably a lot better.

@SLUCHABLUB SLUCHABLUB requested a review from Tomas-Ka May 18, 2026 10:13
Copy link
Copy Markdown
Contributor

@Tomas-Ka Tomas-Ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have the new check-translations action in the general pnpm action for CI. After looking more closely at it I think it's reasonable to let this be it's own worker (instead of bundling it with everything else). I mostly pushed to consolidate since I believed the workflow used the pnpm ci-check command already

Comment thread package.json Outdated
Comment thread dev/check_translations.sh
@SLUCHABLUB
Copy link
Copy Markdown
Contributor Author

I did not add pnpm build since it was wack and seems to mutate files (I'm not totally sure what it "checks").

@SLUCHABLUB SLUCHABLUB requested a review from Tomas-Ka May 18, 2026 20:43
Copy link
Copy Markdown
Contributor

@Tomas-Ka Tomas-Ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, tyvm!

@SLUCHABLUB SLUCHABLUB merged commit 3a30dc4 into new-design May 21, 2026
1 check passed
@SLUCHABLUB SLUCHABLUB deleted the new-design-translation-key-diff branch May 21, 2026 06:29
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Done in CPU May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants